Open
Conversation
nickiaconis
commented
Jul 23, 2021
| setState({ | ||
| loading: false, | ||
| error: null, | ||
| error: new TypeError(`The argument passed to usePromise must be either a promise or a function, but you passed a ${typeof promiseOrFn}`), |
Contributor
Author
There was a problem hiding this comment.
Alternatively, this could throw a type error instead b/c a falsy value in promiseOrFn doesn't satisfy the type specified for the hook argument. Throwing an error might be better than setting an error on the state since this has the potential to be incorrectly interpreted as a rejected promise. 🤷 Would like your input on this please.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increases the specificity of the return type. This allows consumers to make assumptions about the existence of
valuebased on the value/presence ofloadinganderror.For example, this will produce a type error with the current version of
react-promise, but will work as expected with these changes: