server: Add isolated template to index.html #3805
Open
+358
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview deployments |
Host Test Results 1 files ± 0 1 suites ±0 3h 15m 40s ⏱️ + 1h 37m 22s For more details on these errors, see this check. Results for commit 3137cbd. ± Comparison against base commit afd071b. ♻️ This comment has been updated with latest results. |
This reverts commit f096883.
This is akin to how Fastboot does it.
This is the most sensible file to have the new test in but unskipping the whole file brought these back.
These were red herrings, the ultimate fix was the patch to @embroider/webpack.
The server file is pretty big already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This serves a prerendered isolated template for a card if it exists. With this branch deployed to staging:
You can see some layout shifting, and rehydration is in a forthcoming issue; for now, the prerendered HTML is deleted when Ember takes over, so interaction and state may be lost.