Skip to content

Conversation

@lucaslyl
Copy link
Contributor

Problem:

image (1)
  1. Realm.ts had two similar endpoints that caused confusion:
  • /_dependencies - JSONAPI format, supports instances and modules
  • /_card-dependencies - JSON array, instances only (renamed in this PR to
    distinguish these two APIs: /_dependencies/_card-dependencies)
  1. The /_card-dependencies endpoint only supports instances, not modules.

Changes

  1. Renamed one of the /_dependencies endpoints → /_card-dependencies to
    distinguish the two APIs.

  2. Update listing-create(linkSpecs) and listing-update-specs to use /_dependencies instead
    of /_card-dependencies to support both instance and module dependencies.

    • Parse JSONAPI response format (data[].attributes.dependencies)
    • Update Accept header to JSONAPI mime type
    • Extract dependencies from all entries in the JSONAPI data array

This clarifies endpoint usage and enables module dependency support.

@lucaslyl lucaslyl self-assigned this Jan 13, 2026
@lucaslyl lucaslyl requested a review from a team January 13, 2026 04:46
.get(
'/_dependencies',
'/_card-dependencies',
SupportedMimeType.CardDependencies,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardhjtan I will rename this to card-dependencies to better distinguish its API purpose

@github-actions
Copy link

Preview deployments

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

Host Test Results

    1 files  ±0      1 suites  ±0   1h 40m 24s ⏱️ + 2m 6s
1 871 tests ±0  1 856 ✅ +2  15 💤 ±0  0 ❌ ±0 
1 886 runs  ±0  1 871 ✅ +4  15 💤 ±0  0 ❌  - 2 

Results for commit 19afe95. ± Comparison against base commit afd071b.

♻️ This comment has been updated with latest results.

@tintinthong tintinthong marked this pull request as ready for review January 13, 2026 08:48
@lucaslyl lucaslyl merged commit 061b811 into main Jan 14, 2026
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants