This repository was archived by the owner on Apr 21, 2020. It is now read-only.
Open
Conversation
Update build.js
Use cross-spawn when sh is false for better Windows spawning support
Big Commit ahead, please read description -> -> This change is simple as modify the isElegible function to also return the home directory as a possible config file directory, core functions do the rest on finding and parsing the config file -> As this affects a core function all the core tests need to be modified to support using the home directory as an elegible directory -> Custom provider spec had been modified to split test between finding a file target and parsing and checking the targets
Add posibility to use an atom-build config file from the user's home
If target has the "preBuild" attribute and it is a function, it will be called before the build. If "preBuild" returns a promise, build will be started after the promise resolution. "postBuild" hook is called upon child closed. "postBuild" receives a build status as an argument.
Updated appveyor CI methodology
Term.JS is very capable of displaying output targeted
at terminals in HTML. It supports a wide range of control
characters making output display correctly. Advanced stuff
such as full screen renderings work.
There are two caveats with this implementation:
* No longer underline and make links clickable when
error matched. The short key still works, and it
still scrolls the terminal to the correct location.
* Since term.js hard break lines when terminal width
is reached (regardless of occurance of newline char)
it is difficult to find a matched text. The current
implementation decreases the matched text until it
finds a subset that matches. This may of course not
be accurate at all times. But hopefully close enough.
I think the two caveats are minor considering the reduced
maintenance of this package and the immensely improved support
for terminal based output.
Fix incorrectly matched the command definition rather than the actual output.
Use Term.JS rather than custom output
This removes the percentage height. It can now be set at any height directly. Also modifies the terminal output so it always adds show whole rows. I.e. size is rounded to fit rows. Fixes #312
When a build has completed, only reset the focus if we still "own" the focus, i.e. no other focus choices has been made by the user. Fixes #300
Added a drag and resize of the build panel
Only re-focus if we still "own" focus
Handle if project folder has gone away
Atom >= 1.13 doesn't return real path for textEditor.getPath(). In this case, affected projects will not be available for "build".
For example, project is located in `/private/tmp/myproject`
* `fs.realpathSync('/private/tmp/myproject') === '/private/tmp/myproject'`
* `textEditor.getPath() === '/tmp/myproject'`
* `fs.realpathSync(textEditor.getPath() ) === '/private/tmp/myproject'`
Dispatching events seem to not work. Easier and is to check via Atom's documented API which keymaps are registered and trust that their stuff works - which we of course do for many other things anyway.
Fixing keymap specs
Fix spelling: succeding -> succeeding
Fix issue with incorrect path for text editor
add row and column numbers as available command replacement
Thanks to @sphaerophoria for correctly identifying the issue and providing an initial solution in #503. Fixes: #484, #447
They can now be reliably sent through a documented API.
No recursive loop
Busy Signal is most widely adopted and it doesn't make sense to have 2 packages which does the same thing. Get with the program and use `busy-signal`. Fixes #528
Add `.yaml` as an alternative extension.
Adds specs for .yaml file
Use `busy-signal` over `busy`
Only register atomCommandName if it exists
If we don't close stdin, subprocesses that would ask for user input block forever. Since atom-build has no way to interact with the spawned subprocesses, just close it to have them fail.
Reset user-select properly
close stdin in spawned child processes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.