Simpler and more robust Makefile#451
Open
maxim-belkin wants to merge 2 commits intocarpentries:gh-pagesfrom
Open
Simpler and more robust Makefile#451maxim-belkin wants to merge 2 commits intocarpentries:gh-pagesfrom
maxim-belkin wants to merge 2 commits intocarpentries:gh-pagesfrom
Conversation
c81d970 to
ba4f717
Compare
Contributor
Author
|
@fmichonneau, did you want to discuss this PR or did you want someone else to look at it? |
Contributor
|
Overall, I like that this approach leads to more informative error messages. I do worry about the increasing complexity of the file. It would also make things easier to manage if everything was in a file, is it possible? Finally, we need to make sure that we can run |
Contributor
Author
|
I'll rebase this PR once #473 is merged and update it as requested so that we can discuss it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked the Makefile to make it simpler (to understand) and more robust so that people with no experience with Make would see clear error messages when something is not working.
Clear error messages require things like:
To avoid repetition, I extracted these
ifneq .... endiftocommands.mkand createdTOOL_CMDfor eachTOOL.