Skip to content

Update golang + golangci-lint to resolve CVEs #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devanshuVmware merged 2 commits into from
Feb 17, 2026
Merged

Update golang + golangci-lint to resolve CVEs #712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9839038
Update golang + golangci-lint
CodesbyUnnati Jan 17, 2026
5b2c2c5
Bump carvel tools + golang 1.25.7
CodesbyUnnati Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/golangci-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
with:
go-version-file: go.mod
- name: golangci-lint
uses: golangci/golangci-lint-action@v6
uses: golangci/golangci-lint-action@v7
with:
version: v1.64
version: v2.4
args: -v
6 changes: 3 additions & 3 deletions .github/workflows/kind-action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ jobs:
with:
token: ${{ secrets.GITHUB_TOKEN }}
only: ytt, kapp, kbld
ytt: v0.45.4
kapp: v0.58.0
kbld: v0.37.5
ytt: v0.53.0
kapp: v0.65.1
kbld: v0.47.1
# Run benchmark with `go test -bench` and stores the output to a file
- name: Install sg and run e2e tests on kind
run: |
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ jobs:
with:
token: ${{ secrets.GITHUB_TOKEN }}
only: ytt, kapp, kbld, imgpkg, kctrl, vendir
ytt: v0.52.1
kapp: v0.64.2
kbld: v0.47.0
imgpkg: v0.47.0
kctrl: v0.59.0
vendir: v0.45.0
ytt: v0.53.0
kapp: v0.65.1
kbld: v0.47.1
imgpkg: v0.47.1
kctrl: v0.59.2
vendir: v0.45.1
- name: Login to GitHub Container Registry
uses: docker/login-action@v2
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test-gh.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ jobs:
with:
token: ${{ secrets.GITHUB_TOKEN }}
only: ytt, kapp, kbld
ytt: v0.45.4
kapp: v0.58.0
kbld: v0.37.5
ytt: v0.53.0
kapp: v0.65.1
kbld: v0.47.1
- name: Run Tests
run: |
set -e -x
Expand Down
17 changes: 8 additions & 9 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,19 @@
version: "2"
run:
timeout: 5m
linters:
default: none
enable:
- goheader
- revive
- unused
disable-all: true
# all available settings of specific linters
linters-settings:
goheader:
values:
regexp:
copyright-year: 20[0-9][0-9]
template-path: code-header-template.txt
settings:
goheader:
values:
regexp:
copyright-year: 20[0-9][0-9]
template-path: code-header-template.txt
issues:
max-issues-per-linter: 0
max-same-issues: 0
exclude-use-default: false
new-from-rev: ae7b7b79a75756ae3cec92e8bb8c6bf0c4dab48e
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM --platform=$BUILDPLATFORM golang:1.24.10 AS deps
FROM --platform=$BUILDPLATFORM golang:1.25.7 AS deps

ARG TARGETOS TARGETARCH SGCTRL_VER=development
WORKDIR /workspace
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module carvel.dev/secretgen-controller

go 1.24.10
go 1.25.7

require (
github.com/cloudfoundry/bosh-utils v0.0.563 // indirect
Expand Down