Allow user to be set in url on gh-pages#29
Open
kirkins wants to merge 1 commit intocaseyscarborough:gh-pagesfrom
Open
Allow user to be set in url on gh-pages#29kirkins wants to merge 1 commit intocaseyscarborough:gh-pagesfrom
kirkins wants to merge 1 commit intocaseyscarborough:gh-pagesfrom
Conversation
Author
|
P.S. I'm only changing the gh-pages branch not modifying the base library like the other open pull-request. |
caseyscarborough
added a commit
that referenced
this pull request
Aug 12, 2017
|
Just a suggestion, you could use: And then use if statements to put in the default |
Owner
|
I like this idea a lot. I think it could be implemented a little more cleanly using @turquoise-turtle's solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I often found I wanted to look through my history using this but would search every-time.
I wanted to be able to do something like this:
https://kirkins.github.io/github-activity/?user=kirkins
So I figured I'd send a pull request. Though I realize this may just be adding an unneeded feature to something meant to be an mvp.
Best,
Philip