Skip to content

Conversation

@fcbr
Copy link
Member

@fcbr fcbr commented Nov 7, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 7, 2025 19:31
@fcbr fcbr self-assigned this Nov 7, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new GitHub Actions workflow to automatically manage stale issues and pull requests by marking them inactive after a period of no activity and eventually closing them.

Key Changes

  • Introduces a scheduled workflow that runs daily at 14:17 UTC using the actions/stale@v5 action
  • Configures basic stale detection with custom labels ('no-issue-activity' and 'no-pr-activity')
  • Sets up appropriate permissions for issue and PR management

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

stale-issue-message: 'Stale issue, will close soon.'
stale-pr-message: 'Stale pull request, will close soon.'
stale-issue-label: 'no-issue-activity'
stale-pr-label: 'no-pr-activity'
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stale workflow is missing critical timing parameters. Without specifying days-before-stale and days-before-close, the action will use its default values (60 days before stale, 7 days before close). These defaults may not match your project's needs and should be explicitly configured for clarity and maintainability.

Consider adding these parameters:

days-before-stale: 30
days-before-close: 7
Suggested change
stale-pr-label: 'no-pr-activity'
stale-pr-label: 'no-pr-activity'
days-before-stale: 30
days-before-close: 7

Copilot uses AI. Check for mistakes.
Comment on lines +24 to +25
stale-issue-message: 'Stale issue, will close soon.'
stale-pr-message: 'Stale pull request, will close soon.'
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stale messages are not informative or helpful. Users should be given clear guidance on what actions they can take to prevent closure and why the issue/PR is being marked as stale.

Consider more descriptive messages like:

stale-issue-message: 'This issue has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs. Please comment if this issue is still relevant.'
stale-pr-message: 'This pull request has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs. Please update or comment if this PR is still relevant.'
Suggested change
stale-issue-message: 'Stale issue, will close soon.'
stale-pr-message: 'Stale pull request, will close soon.'
stale-issue-message: 'This issue has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs. Please comment if this issue is still relevant.'
stale-pr-message: 'This pull request has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs. Please update or comment if this PR is still relevant.'

Copilot uses AI. Check for mistakes.
stale-issue-message: 'Stale issue, will close soon.'
stale-pr-message: 'Stale pull request, will close soon.'
stale-issue-label: 'no-issue-activity'
stale-pr-label: 'no-pr-activity'
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow lacks important configuration options that would make the stale bot more useful:

  • No exempt-issue-labels or exempt-pr-labels to protect certain issues/PRs from being marked stale
  • No close-issue-message or close-pr-message to inform users when items are actually closed
  • No operations-per-run limit (defaults to 30, which may be too low for repositories with many stale items)

Consider adding these options to provide better control and user experience:

exempt-issue-labels: 'pinned,security,bug'
exempt-pr-labels: 'pinned,work-in-progress'
close-issue-message: 'This issue was automatically closed due to inactivity.'
close-pr-message: 'This pull request was automatically closed due to inactivity.'
Suggested change
stale-pr-label: 'no-pr-activity'
stale-pr-label: 'no-pr-activity'
exempt-issue-labels: 'pinned,security,bug'
exempt-pr-labels: 'pinned,work-in-progress'
close-issue-message: 'This issue was automatically closed due to inactivity.'
close-pr-message: 'This pull request was automatically closed due to inactivity.'
operations-per-run: 100

Copilot uses AI. Check for mistakes.
@fcbr fcbr merged commit 5bef50f into main Nov 10, 2025
9 checks passed
@fcbr fcbr deleted the fcbr-patch-1 branch November 10, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants