Skip to content

Fix default value of gop #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xlz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix default value of gop #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion include/zdepth.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,14 +213,19 @@ uint16_t AzureKinectDequantizeDepth(uint16_t quantized);
enum class EncodeMode {
// Quantized within [200, 11840] mm. 12 bit/pixel
kAzureKinectQuantized = 0b0000,

// Not quantized within [1, 511] mm. 10 bit/pixel
kNotQuantized511mm = 0b0001,

// Not quantized within [1, 1023] mm. 11 bit/pixel
kNotQuantized1023mm = 0b0010,

// Not quantized within [1, 2047] mm. 12 bit/pixel
kNotQuantized2047mm = 0b0011,

// Not quantized within [1, 4095] mm. 13 bit/pixel
kNotQuantized4095mm = 0b0100,

// Not quantized within [1, 8191] mm. 14 bit/pixel
kNotQuantized8191mm = 0b0101,
};
Expand Down Expand Up @@ -353,7 +358,7 @@ class DepthCompressor
// Packs the 16-bit overruns into 12-bit values and apply Zstd
std::vector<uint8_t> Packed;

int gop_ = 30;
int gop_ = 1;
EncodeMode encode_mode_ = EncodeMode::kAzureKinectQuantized;

void CompressImage(
Expand Down
2 changes: 1 addition & 1 deletion src/zdepth.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ void Unpack12(
int GetCutoffDepth(EncodeMode mode) {
switch (mode) {
case EncodeMode::kAzureKinectQuantized:
return 2048;
return 11840;
case EncodeMode::kNotQuantized511mm:
return 512;
case EncodeMode::kNotQuantized1023mm:
Expand Down