Skip to content

Break main template into components#106

Open
aaronfischer wants to merge 107 commits intomasterfrom
break-main-template-into-components
Open

Break main template into components#106
aaronfischer wants to merge 107 commits intomasterfrom
break-main-template-into-components

Conversation

@aaronfischer
Copy link
Contributor

@aaronfischer aaronfischer commented Aug 13, 2018

What does this pull request do?

Break main ember-tabular.hbs into subcomponents to allow for easier updating/extending.

What are the relevant issues?

#105

Any background context you want to provide?

Depends upon #93

Definition of Done:

Each should be selected to indicate consideration for applicability and/or completion.

  • Does this PR fully satisfy the scope as outlined in the referenced issue(s)?
  • Is there appropriate test coverage?
  • Is static analysis resulting in a satisfactory score?
  • If adding new dependencies, does pip requirements need to be updated?
  • Has the change log been updated?

aaronfischer added 30 commits May 25, 2017 15:57
@aaronfischer
Setting up changelog for v0.2.0
f089918
@aaronfischer
Correct changelog entries under new tag
6e46f3d
@aaronfischer
Setup yuidocs and slim down README in favor of API documentation
386457d
@aaronfischer
Create yuidocs for subcomponents
e23084a
@aaronfischer
Add yuidocs for main component
facd9bf
@aaronfischer
Add further docs
c533440
@aaronfischer
Upgrade ember-cli-mirage to 0.3.2
9d2a570
@aaronfischer
Upgrade to ember-cli 2.13.2
45cef62
@aaronfischer
Upgrade node and .gitignore with ember-try setup
55271f6
@aaronfischer
Merge branch 'upgrade-to-ember-cli-2.13.2' into dynamic-columns
879fd1d
@aaronfischer
Fixing merge error
3f51a82
@aaronfischer
WIP, initial pass at generating the columns based on the modelName
f39cfda
@aaronfischer
Setup a columns array and columnsMap of all potential columns
41826bc
@aaronfischer
Setup a way to automatically render the template based on the model data
3eba20a
@aaronfischer
Setup ember-tabular-cell for rendering specific cell based on column …
683c676 
…data
@aaronfischer
WIP, setup custom override of ember-tabular-cell on a per column.prop…
92f5307 
…erty basis
@aaronfischer
WIP, use find-by and an external config to define when columns need c…
e2da323 
…ustom templates
@aaronfischer
Setup compare-with helper that accepts columnsConfig property and col…
96dc55e 
…umn property
@aaronfischer
Change name to be more contextual
2e3d2b8
@aaronfischer
Setup columnsConfig and automatically merge with the columns array
6ae44e0
@aaronfischer
Fix mock user data
f5942c1
@aaronfischer
Do not require columns array or objects to be ember objects, support …
15e8d10 
…non-KVO compliant
@aaronfischer
Set individual sort properties
38ed3cd
@aaronfischer
Fix scoping issue when setting the sort asc/desc classes
18c8473
@aaronfischer
Change name to column from cell
c020669
@aaronfischer
Setup helper for determining property name
2333f0d
@aaronfischer
WIP, setup way to initialize columns array based on initialized subco…
c5b5b5b 
…mponent columns
@aaronfischer
Setup a helper for determining the passed in column defaults
5b68e3e
@aaronfischer
Remove console.log from columns and add in defaults when column is in…
e68760d 
…itialized automatically
@aaronfischer
Setup way for ember-tabular to know that the custom yields are complete
599efb4
@aaronfischer
When setting the default valus of the registryDiff, reference the col…
a2d1629 
…umnOrder to set isActive

Reference issue #149
@aaronfischer
Add wrapperHeader and wrapperFooter as additional yields
ea98101
@aaronfischer
Fix indent
0fd1064
@aaronfischer
Refactor to run updateSortUI on didRender to catch when tabular gener…
effd2bb 
…ates columns
@aaronfischer
Shorten isCustomTemplate to isCustom, make isCustom consistent
09935e7
@aaronfischer
Clean up dummy template
67c1bbe
@aaronfischer
Create sub component for loading logic
1787c7b
@aaronfischer
Rename ember-tabular-footer to registry and restructure how the regis…
155caa0 
…try is built and fix issue where slight delay would cause loading to dissapear
@aaronfischer
Fix loading icon appearing over loading text
6e866eb
@aaronfischer
Add options to column-select
356ae64
@aaronfischer
Allow clicking within the column select and not closing the window
762f152
@aaronfischer
Refactor to prevent need to doubleclick to close dropdown
ef9ca78
@aaronfischer
Ensure we display errors caused within ember-tabular request() to the…
f6a30ed 
… user instead of swallowing them

Reference issue #98
@aaronfischer
Fix deprecation warning in recent ember-cli versions around Ember.Str…
85b0090 
…ing.dasherize/camelize
@aaronfischer
Revert "Fix deprecation warning in recent ember-cli versions around E…
21b3f30 
…mber.String.dasherize/camelize"

This reverts commit 85b0090.
@aaronfischer
Pushes undefined columns sort to the back of the list instead of the …
382cef5 
…front

Reference issue #100
@aaronfischer
WIP, attempt to save columnOrder and allow it to persist within contr…
d189bef 
…oller
@aaronfischer
Allow columns to be set and registered even when there is no table data
88787d1 
Reference issue #99
@aaronfischer
Merge branch 'dynamic-columns-no-config' into dynamic-columns-no-conf…
659caa3 
…ig-save-columnOrder
@aaronfischer
Make columnOrder the main source for displaying columns if it is used…
0a9629e 
…, pass this into the individual column to check for display

Reference issue #101
@aaronfischer
Add test to verify that columnOrder can persist
d00dff3
@aaronfischer
Fix issue that may trigger calling set on destroyed object
91dc908
@aaronfischer
Setup page reset if filter is changed
b75e52d 
Reference issue #102
@aaronfischer
Setup onFiltering event that fires when an input or dropdown is focus…
daff84c 
…ed within the thead filters
@aaronfischer
Setup ember-tabular-thead component to make to easier overriding/exte…
1249e4f 
…nding
@aaronfischer
Setup ember-tabular-tbody subcomponent
cd1f0e7
@aaronfischer
Add/updating ember-tabular-footer and ember-tabular-alert
9b2fbdc
@aaronfischer
Update changelog
6a1d4dd
@aaronfischer
Pass additional properties to subcomponents
b4162ba
@aaronfischer
Setup a way to refreshTabular by toggling a property
6f93298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aaronfischer