Dev #3
Dev #3
Conversation
…ssion , xet, ipfs , benchmarks , bug fixes , peer , piece , executor , daemon , cli , config, and more
…ssion , xet, ipfs , benchmarks , bug fixes , peer , piece , executor , daemon , cli , config, and more
…h ci separation , adds fixes for bugs identified while testing , refactors tests , and more !
…h ci separation , adds fixes for bugs identified while testing , refactors tests , and more !
…h ci separation , adds fixes for bugs identified while testing , refactors tests , and more !
…h ci separation , compatibility tests, adds missing deps
* solves test failures , lint checks , ci docs build , main / dev branch ci separation , adds fixes for bugs identified while testing , refactors tests , and more ! * solves test failures , lint checks , ci docs build , main / dev branch ci separation , compatibility tests, adds missing deps
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| connect_to_peer: Establish connection to a peer | ||
| discover_peers: Discover peers via DHT or trackers | ||
| """ | ||
| ``` |
There was a problem hiding this comment.
Python docstring accidentally pasted into markdown documentation
A Python module docstring (lines 281-294) appears to have been accidentally pasted into this markdown rules file. The content describes peer connection classes and functions with a closing """ quote, which doesn't belong in markdown documentation. This creates malformed documentation content.
| # 4. Empty values will use defaults | ||
| # 5. Environment variables take precedence over config file values | ||
| # 6. CLI arguments take precedence over environment variables | ||
| # 7. Use quotes for values containing spaces or special characters |
There was a problem hiding this comment.
Duplicate configuration content at end of file
Lines 453-469 are exact duplicates of lines 430-446, containing repeated CCBT_ENABLE_PROFILING, CCBT_PROFILE_OUTPUT, testing settings, and the NOTES section. This appears to be accidental copy-paste duplication.
| read_ahead_kib = 128 | ||
| enable_io_uring = false | ||
| download_path = "" | ||
| download_dir = "C:\\Users\\MeMyself\\Downloads" |
There was a problem hiding this comment.
Hardcoded Windows user path in configuration file
The download_dir setting contains a hardcoded Windows path "C:\\Users\\MeMyself\\Downloads" which appears to be a developer's local configuration accidentally committed. This path references a specific username and will not work for other users. The download_path field on line 120 is correctly empty, suggesting this was an unintended commit. This could cause confusion or errors for users who use this config as a reference.
| - name: Checkout main branch | ||
| run: | | ||
| git fetch origin main | ||
| git checkout main |
There was a problem hiding this comment.
Release workflow doesn't merge source branch into main
The workflow claims to be an "Automated release process from dev to main branch" but it only updates version numbers on main without actually merging content from the dev branch. After checking out the source branch to get the version, it fetches and checks out main, then only modifies version files. The actual code changes from dev are never merged into main, meaning the version bump occurs without the corresponding code changes. This workflow will produce releases with incorrect code.
Note
Modernizes project automation, documentation, and configuration while applying a Windows runtime fix.
dev, security onmain), and simplifies CI to lint/type-checkccbt.tomldefaults and a rich.envtemplate; extends internal development/performance/monitoring rulesWindowsSelectorEventLoopPolicyto avoid UDP issues; minor typing tweaks in__main__; version set to0.0.1Written by Cursor Bugbot for commit 5b36550. This will update automatically on new commits. Configure here.