GBSA-4710 - Shreyas: Completed 00_about_conditionals.sh koan + README update#12
GBSA-4710 - Shreyas: Completed 00_about_conditionals.sh koan + README update#12ShreyasMahen wants to merge 1 commit intoccameron-gb:masterfrom
Conversation
ShreyasMahen
commented
Oct 15, 2025
ShreyasMahen
commented
- Added a new section under the README to summarize lessons learned from the 00_about_conditionals.sh koan
- Included key points about spacing, quoting, and comparison operators in Bash conditionals
- Maintained consistent tone and formatting with the rest of the document
- Added a new section under the README to summarize lessons learned from the 00_about_conditionals.sh koan - Included key points about spacing, quoting, and comparison operators in Bash conditionals - Maintained consistent tone and formatting with the rest of the document
Daniel-Lopez246
left a comment
Daniel-Lopez246
left a comment
There was a problem hiding this comment.
I believe Chris want's the README and your file you were assigned as different pull requests and make sure to include the Notion ID in the Pull Request title
|
I think we can overlook the combined README+Bash PR, but @ShreyasMahen including the Notion ID is an easy thing you can do to this PR now. Also, look! We have conflicts that need to be resolved! Take a look Shreyas, those will need to be resolved before GitHub gives us the option of merging your changes. |
Daniel-Lopez246
changed the title
|
@x-anudeep and @AmalKrishna1 - I'm going to ask you two to be the ones to review this PR. I think Daniel is now listed as a reviewer too. As far as I know we can have more than the minimum number of reviewers. |
Daniel-Lopez246
left a comment
Daniel-Lopez246
left a comment
There was a problem hiding this comment.
Added Notion ID to title
AmalKrishna1
left a comment
AmalKrishna1
left a comment
There was a problem hiding this comment.
Great job on the koans the descriptions are really well done and explain the code pretty well! There are still merge conflicts existing at this point, but great job on completion!
4 participants
