Add protocol option to ssl-context#85
Open
leek5pin wants to merge 1 commit intocch1:masterfrom
leek5pin:add-protocol-option
Open
Add protocol option to ssl-context#85leek5pin wants to merge 1 commit intocch1:masterfrom leek5pin:add-protocol-option
leek5pin wants to merge 1 commit intocch1:masterfrom
leek5pin:add-protocol-option
Conversation
cch1
reviewed
Feb 14, 2020
Owner
cch1
left a comment
cch1
left a comment
There was a problem hiding this comment.
A test would be the icing on the cake. The implementation looks pretty simple and I'll pull as soon as you can demonstrate in a test that the protocol can be configured. There are already tons of tests so you should be able to find a good starting point.
Owner
|
@sean-stockholm Any chance you can add a test? |
Author
|
I've been swamped with moving. I'll find some time to make a test before EOD Monday. |
Owner
Which Monday? :) I'm in a good place to merge this PR if you can get a test in place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting up the
ssl-contextI need to useTLSv1.2or my request will fail. That is an optional parameter in the setup through the java api, but is not in your http async client. As result, on creation of thessl-contextit defaults toTLS. The proposed change would add an optional:protocolkey to thessl-contextfunction which would default toTLSwhen not present, but could be specified.