Skip to content

Comments

Revise addr space#128

Open
woodard wants to merge 19 commits intoccoutant:mainfrom
woodard:revise-addr-space
Open

Revise addr space#128
woodard wants to merge 19 commits intoccoutant:mainfrom
woodard:revise-addr-space

Conversation

@woodard
Copy link
Contributor

@woodard woodard commented Dec 8, 2025

With the latest changes. I feel like it is ready to review. Turning it into a PR also allows people to comment on the patch.

Begin working on revising the address space proposal. This mostly
reorders the text and adds notes for work to be done.

Signed-off-by: Ben Woodard <woodard@redhat.com>
* Change the name of the operator
* Remove implicit pointer stuff
* Remove CFA/CFI stuff deferred until the CFA/CFI proposal.
* Notable rewriting.

Signed-off-by: Ben Woodard <woodard@redhat.com>
Too many changes to describe fully.

Signed-off-by: Ben Woodard <woodard@redhat.com>
Cary's email and Tony's response both made some important points which need
to be discussed in the group as a whole.

Signed-off-by: Ben Woodard <woodard@redhat.com>
Fixed a few grammar and spelling mistakes.
Changed the way I presented tables in md

Signed-off-by: Ben Woodard <woodard@redhat.com>
@woodard woodard marked this pull request as draft December 8, 2025 22:41
Fix several bugs that Baris pointed out.

Signed-off-by: Ben Woodard <woodard@redhat.com>
Address comments and questions that were discussed in the Dec 17 GPU
meeting as well as comments that Tony entered in the PR.

Signed-off-by: Ben Woodard <woodard@redhat.com>
I missed a few later breaking comments in the PR. Added those changes.

Signed-off-by: Ben Woodard <woodard@redhat.com>
Signed-off-by: Ben Woodard <woodard@redhat.com>
Copy link
Contributor

@t-tye t-tye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through and suggested a collection of changes, but overall I really like this:-)

Tony did a careful read through and picked up some minor errors. I
fixed most of them. Only two are left, I believe that both of those
require discussion.

Signed-off-by: Ben Woodard <woodard@redhat.com>
Fix action item before meeting.
Add some notes to a problematic paragraph.

Signed-off-by: Ben Woodard <woodard@redhat.com>
Baris pointed out several problems on the PR. This attempts to address
most of them.

Signed-off-by: Ben Woodard <woodard@redhat.com>
1. This fixes a couple of minor bugs that Baris found.
2. It also rearranges where I describe the problems with xderef
3. However, the biggest change is rewriting the problematic paragraph
describing DW_AT_address_space/

Signed-off-by: Ben Woodard <woodard@redhat.com>
Signed-off-by: Ben Woodard <woodard@redhat.com>
Baris provided additional feedback and I applied many of his suggested
changes.

Signed-off-by: Ben Woodard <woodard@redhat.com>
As discussed in the meeting, the algorithmic description about how the
size changes are handled when A doesn't match the size of the address
space is replaced with simpler text.

Signed-off-by: Ben Woodard <woodard@redhat.com>
@woodard woodard marked this pull request as ready for review February 5, 2026 21:10
@woodard woodard requested a review from t-tye February 5, 2026 21:12
Applied all of Baris's suggestions from his final review.
Fixed the verb agreement with undo vs. undoes in the introductory text.
Adjusted the description of DW_OP_mem to address Tony's concern.

Signed-off-by: Ben Woodard <woodard@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants