Skip to content

Conversation

@jmp1985
Copy link
Collaborator

@jmp1985 jmp1985 commented Jun 17, 2025

This should update workflows to allow the package to be published to Pypi

@JatGreer
Copy link
Collaborator

Looks reasonable to me. I usually use a slightly different setup including testpypi as an error check such as in this example: https://github.com/ccpem/empiarreader/blob/main/.github/workflows/python-publish.yml, but this looks like it should work. Looks like will only know for sure when a new release is created.

@JatGreer JatGreer self-requested a review June 18, 2025 16:09
@JatGreer
Copy link
Collaborator

I was assigned to the MR but not as a reviewer. So I have added myself as a reviewer and approved. I'll leave it to you @jmp1985 to do the actual merge and create a release and check the pypi release it updated.

Are you happy to maintain the pypi release going forward? If you need to hand it off to ccpem then we'll need to be added as owners of the profet pypi project.

@jmp1985
Copy link
Collaborator Author

jmp1985 commented Jun 19, 2025

@JatGreer I am happy to add ccpem as an owner of the profet repo. What is the username on Pypi?

@jmp1985 jmp1985 merged commit c80fd35 into ccpem:main Jun 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants