Skip to content

Fixing unit tests=#65

Merged
cdisselkoen merged 1 commit intomainfrom
bugfix/aaronjeline/tests
Nov 8, 2023
Merged

Fixing unit tests=#65
cdisselkoen merged 1 commit intomainfrom
bugfix/aaronjeline/tests

Conversation

@aaronjeline
Copy link

Issue #, if available:
N/A
Description of changes:
Not sure how this got past CI, but looks like we had some out of date tests.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cdisselkoen
Copy link
Contributor

cdisselkoen commented Nov 7, 2023

Looks like we have a race condition, your CI in this PR won't pass until we merge #66, while my CI for #66 won't pass until we merge this

@cdisselkoen
Copy link
Contributor

Merging this despite CI because CI is failing due to an unrelated issue which will be fixed in #66

@cdisselkoen cdisselkoen merged commit 1918739 into main Nov 8, 2023
@cdisselkoen cdisselkoen deleted the bugfix/aaronjeline/tests branch November 8, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants