Conversation
Generators may generate `is` based on an `enable_is` flag. This is disabled for differential testing because `is` is not modeled in dafny, but it is enabled for property tests.
Contributor
Author
|
Marking as ready for review. I ran the DRT targets locally (w/ #155) for a few minutes, and didn't see any failures. Will rely on our nightly fuzzing runs to find more subtle issues. |
cdisselkoen
approved these changes
Nov 16, 2023
Contributor
cdisselkoen
left a comment
cdisselkoen
left a comment
There was a problem hiding this comment.
I didn't look at the proofs/lemmas, but the rest of the changes look reasonable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add the
isoperator to Dafny, matching the corresponding implementation in Lean (#138).Will mark as ready for review once I've tested that it works with #145.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.