Entity Slicing: Support loading of particular entity ancestors#1171
Closed
oflatt wants to merge 6 commits intooflatt/entity-manifest-integration-testsfrom
Closed
Entity Slicing: Support loading of particular entity ancestors#1171oflatt wants to merge 6 commits intooflatt/entity-manifest-integration-testsfrom
oflatt wants to merge 6 commits intooflatt/entity-manifest-integration-testsfrom
Conversation
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
Signed-off-by: oflatt <oflatt@gmail.com>
7a436db to
a5d0aa9
Compare
Signed-off-by: oflatt <oflatt@gmail.com>
Contributor
Author
Signed-off-by: oflatt <oflatt@gmail.com>
This was referenced Sep 11, 2024
Contributor
|
Closed in favor of a single PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description of changes
This PR extends entity manifests to describe in particular what Cedar ancestors are required. This can greatly reduce the data required, since entities may have many ancestors. This change is implemented by re-using the existing access trie data structure to describe all the ancestors required.
PR stack:
#1102
#1105
#1154
#1156
#1171 (This PR)
#1196
#1208
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., changes to the signature of an existing API).cedar-policy(e.g., addition of a new API).cedar-policy.cedar-policy-core,cedar-validator, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):cedar-spec, and how you have tested that your updates are correct.)cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)