Skip to content

Make format and check-parse CLI subcommands consistent#408

Merged
john-h-kastner-aws merged 3 commits intocedar-policy:mainfrom
svanderbleek:fix/svanderbleek/cli-positional-argument-consistent
Nov 7, 2023
Merged

Make format and check-parse CLI subcommands consistent#408
john-h-kastner-aws merged 3 commits intocedar-policy:mainfrom
svanderbleek:fix/svanderbleek/cli-positional-argument-consistent

Conversation

@svanderbleek
Copy link
Contributor

@svanderbleek svanderbleek commented Nov 7, 2023

Description of changes

Issue #403

Based on discussion of format and check-parse in linked issue, specifically:

If we make format use -p and --policies instead of a positional argument, then I think we can call it good.

This should close that issue out by making the two subcommands consistent. It only requires a small renaming change for format in the code. I updated the changelog to note the removal of the positional argument for format.

Checklist for requesting a review

The change in this PR is:

  • A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).

I confirm that this PR:

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).

I confirm that cedar-spec:

  • Does not require updates because my change does not impact the Cedar Dafny model or DRT infrastructure.

Disclaimer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@john-h-kastner-aws john-h-kastner-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks again!

@john-h-kastner-aws john-h-kastner-aws linked an issue Nov 7, 2023 that may be closed by this pull request
@svanderbleek
Copy link
Contributor Author

Cool, just had a to fix a failing test I missed for the positional change.

@svanderbleek
Copy link
Contributor Author

I don't understand what the "Build Downstream Dependencies" is doing.

Copy link
Contributor

@john-h-kastner-aws john-h-kastner-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing downstream is due to #393. Nothing to fix here.

@john-h-kastner-aws john-h-kastner-aws merged commit a664991 into cedar-policy:main Nov 7, 2023
shaobo-he-aws pushed a commit that referenced this pull request May 20, 2025
benelser pushed a commit to benelser/cedar that referenced this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make options consistent across CLI sub-commands

3 participants