Make format and check-parse CLI subcommands consistent#408
Merged
john-h-kastner-aws merged 3 commits intocedar-policy:mainfrom Nov 7, 2023
Conversation
andrewmwells-amazon
approved these changes
Nov 7, 2023
john-h-kastner-aws
approved these changes
Nov 7, 2023
Contributor
john-h-kastner-aws
left a comment
There was a problem hiding this comment.
Looks good. Thanks again!
Contributor
Author
|
Cool, just had a to fix a failing test I missed for the positional change. |
Contributor
Author
|
I don't understand what the "Build Downstream Dependencies" is doing. |
john-h-kastner-aws
approved these changes
Nov 7, 2023
Contributor
john-h-kastner-aws
left a comment
There was a problem hiding this comment.
Failing downstream is due to #393. Nothing to fix here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #403
Based on discussion of format and check-parse in linked issue, specifically:
This should close that issue out by making the two subcommands consistent. It only requires a small renaming change for format in the code. I updated the changelog to note the removal of the positional argument for format.
Checklist for requesting a review
The change in this PR is:
cedar-policy(e.g., changes to the signature of an existing API).I confirm that this PR:
I confirm that
cedar-spec:Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.