Conversation
The partial schema PR inadvertantly changed the behavior of, e.g., `princpal in Action::"view"` to be an error, claiming that the `Action` entity type is not defined. It should instead recognize that actions may only be `in` other actions and give the expression type `False`. Our unit tests check the `User::"alice" in Action::"view"` case, but did not test the case when the left side of the `in` was a var.
aaronjeline
approved these changes
Dec 1, 2023
khieta
approved these changes
Dec 1, 2023
Contributor
khieta
left a comment
khieta
left a comment
There was a problem hiding this comment.
Left some minor comments.
khieta
approved these changes
Dec 1, 2023
john-h-kastner-aws
added a commit
that referenced
this pull request
Dec 1, 2023
john-h-kastner-aws
added a commit
that referenced
this pull request
Dec 1, 2023
benelser
pushed a commit
to benelser/cedar
that referenced
this pull request
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The partial schema PR (#79) inadvertently changed the behavior of, e.g.,
principal in Action::"view"to be an error, claiming that theActionentity type is not defined. It should instead recognize that actions may only beinother actions and give the expression typeFalse. Our unit tests checked theUser::"alice" in Action::"view"case, but did not test when the left side of theinwas a var.The change in this PR is (choose one, and delete the other options):
I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.