Fix typechecking in for action in different namespaces#704
Merged
john-h-kastner-aws merged 4 commits intomainfrom Mar 8, 2024
Merged
Fix typechecking in for action in different namespaces#704john-h-kastner-aws merged 4 commits intomainfrom
in for action in different namespaces#704john-h-kastner-aws merged 4 commits intomainfrom
Conversation
Fix #642 Signed-off-by: John Kastner <jkastner@amazon.com>
Signed-off-by: John Kastner <jkastner@amazon.com>
john-h-kastner-aws
force-pushed
the
jkastner/cross_ns_action_in
branch
from
77a7e87 to
00e6051
Compare
shaobo-he-aws
approved these changes
Mar 8, 2024
3 tasks
khieta
pushed a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: John Kastner <jkastner@amazon.com> Signed-off-by: Kesha Hietala <khieta@amazon.com>
khieta
pushed a commit
that referenced
this pull request
Mar 12, 2024
Signed-off-by: John Kastner <jkastner@amazon.com>
benelser
pushed a commit
to benelser/cedar
that referenced
this pull request
Jan 16, 2026
…y#704) Signed-off-by: John Kastner <jkastner@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Makes the easy fix to #642. Actions in different namespaces were incorrectly considered incomparable by the typechecking rule for
in. Update that function so that the comparison is allowed.This can be released in the next patch/minor release. Per #638, we might be able to get rid of this error variant entirely, but that would likely wait for 4.0.
This changes a typechecking rule, so it might seem to require a spec update, but IIRC, the Lean spec would already allow these policies, and DRT allows for this difference. Also, we don't generate schema with multiple namespaces, so DRT couldn't fail anyways.
This bug was introduced by #282 which was released with version 3.0, so we don't need to backport the fix.
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy.I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.