Skip to content

cluster/ceph: fix bug in setting crush_profile #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clwluvw wants to merge 2 commits into
base: master
Choose a base branch
from
Open

cluster/ceph: fix bug in setting crush_profile #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ee1126
cluster/ceph: Use crush_rule instead of crush_ruleset
clwluvw Dec 11, 2020
55643b9
cluster/ceph: revoke crush_profile index based
clwluvw Dec 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions cluster/ceph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,14 +756,7 @@ def mkpool(self, name, profile_name, application, base_name=None):
continue_if_error=False).communicate()

if crush_profile:
try:
rule_index = int(crush_profile)
# set crush profile using the integer 0-based index of crush rule
# displayed by: ceph osd crush rule ls
ruleset = crush_profile
except ValueError:
ruleset = self.get_ruleset(crush_profile)
common.pdsh(settings.getnodes('head'), 'sudo %s -c %s osd pool set %s crush_ruleset %s' % (self.ceph_cmd, self.tmp_conf, name, crush_profile),
common.pdsh(settings.getnodes('head'), 'sudo %s -c %s osd pool set %s crush_rule %s' % (self.ceph_cmd, self.tmp_conf, name, crush_profile),
continue_if_error=False).communicate()

logger.info('Checking Health after pool creation.')
Expand Down
2 changes: 1 addition & 1 deletion example/example-kvmrbdfio.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ cluster:
pg_size: 64
pgp_size: 64
replication: 3
crush_profile: 1
crush_profile: replicated_rule
benchmarks:
kvmrbdfio:
fio_cmd: /usr/local/bin/fio
Expand Down