Skip to content

Conversation

@nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Oct 6, 2025

  • cleanup the docker installation.

@nizamial09
Copy link
Member Author

i haven't tested this in the jenkins yet by updating the job configuration yet. Only done it in my local VM (which worked fine). Will wait for an approval before testing it out in the jenkins machines.

@nizamial09 nizamial09 changed the title cephadm-dashboard-e2e: install docker from ubuntu's repo cephadm-dashboard-e2e: replace docker with podman Oct 8, 2025
@nizamial09
Copy link
Member Author

replacing docker with podman.

@dmick
Copy link
Member

dmick commented Oct 14, 2025

This is good as far as it goes, but I see two problems:

  1. there are build hosts that have installed docker in the standard way from the standard repos, and rely on it, so "is docker present, if so remove it" is going to break those hosts

  2. the broken hosts will stay broken until they happen to be selected for a dashboard run

so this isn't sufficient, and I don't have time to make it better this week

- cleanup the docker installation if its installed through docker-ce

Signed-off-by: Nizamudeen A <nia@redhat.com>
@nizamial09
Copy link
Member Author

  1. there are build hosts that have installed docker in the standard way from the standard repos, and rely on it, so "is docker present, if so remove it" is going to break those hosts

@dmick i've modified the condition to check whether docker is installed through the docker official repo (docker-ce) and then only remove it. Maybe its more safer than before. Again I tried this out in my local VM which succesfully worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants