Skip to content

Comments

RunList: add flavor column to runs page#102

Merged
VallariAg merged 1 commit intoceph:mainfrom
Matan-B:wip-matanb-pulpito-flavor
Jul 18, 2025
Merged

RunList: add flavor column to runs page#102
VallariAg merged 1 commit intoceph:mainfrom
Matan-B:wip-matanb-pulpito-flavor

Conversation

@Matan-B
Copy link

@Matan-B Matan-B commented Jun 29, 2025

paddles api appear to support flavor already, let's showcase it.

@netlify
Copy link

netlify bot commented Jun 29, 2025

Deploy Preview for pulpito ready!

Name Link
🔨 Latest commit f0d6016
🔍 Latest deploy log https://app.netlify.com/projects/pulpito/deploys/68775560a8885f000835c969
😎 Deploy Preview https://deploy-preview-102--pulpito.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Matan-B
Copy link
Author

Matan-B commented Jun 29, 2025

@VallariAg, @zmc ,- Can you please take a look? Thanks!

edit: Hmm, preview is off, can you help me understand what's missing here please?

@VallariAg
Copy link
Member

@Matan-B
I checked the paddles Runs table and I don't see flavor being exported as part of /runs returned data: https://github.com/ceph/paddles/blob/a2f278c599651b60975249258b1b36a682cffce1/paddles/models/runs.py#L95

I opened a draft PR to include flavor as part of the result: ceph/paddles#137
I haven't tested it locally yet, I'll mark it as "ready to review" as soon as I've tested it. Once that PR is merged, the preview for this PR should start showing flavor in the table.

Copy link
Member

@zmc zmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once paddles support has landed I think this is ready to merge

@Matan-B
Copy link
Author

Matan-B commented Jul 16, 2025

ceph/paddles#137 was merged!
I'll rebase this pr to re-trigger the preview.

Based on ceph/paddles#137

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-pulpito-flavor branch from df40fa1 to f0d6016 Compare July 16, 2025 07:31
@VallariAg VallariAg merged commit 55cb494 into ceph:main Jul 18, 2025
6 checks passed
VallariAg added a commit that referenced this pull request Jul 18, 2025
RunList: add flavor column to runs page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants