Skip to content

Comments

teuthology/suite/run.py: Improve ScheduleFail exception#1924

Open
kamoltat wants to merge 3 commits intoceph:mainfrom
kamoltat:wip-ksirivad-teuth-suite-exception
Open

teuthology/suite/run.py: Improve ScheduleFail exception#1924
kamoltat wants to merge 3 commits intoceph:mainfrom
kamoltat:wip-ksirivad-teuth-suite-exception

Conversation

@kamoltat
Copy link
Member

@kamoltat kamoltat commented Mar 7, 2024 •
edited
Loading

(Merge this first before ceph/teuthology-api#51 and ceph/pulpito-ng#23)

As per: ceph/pulpito-ng#23

  1. Improve teuthology-schedule exceptions by utilizing ScheduleFail and GitError
  2. make teuthology.suite.main return job_count such that teuthology-api and Pulpito-ng can use it.
  3. edit teuthology.sh & start.sh such that we -x earlier for better output when watching the docker-compose do it's thing.

Fixes: https://tracker.ceph.com/issues/64820

@kamoltat kamoltat force-pushed the wip-ksirivad-teuth-suite-exception branch 3 times, most recently from 9ca70bd to 5fe4921 Compare March 13, 2024 20:05
@kamoltat kamoltat changed the title [DNM] teuthology/suite/run.py: Added some loggings and ScheduleFail exception teuthology/suite/run.py: Improve ScheduleFail exception Mar 13, 2024
@kamoltat kamoltat force-pushed the wip-ksirivad-teuth-suite-exception branch from 5fe4921 to 3f548c6 Compare March 13, 2024 21:02
kamoltat
kamoltat commented Mar 13, 2024
View reviewed changes
teuthology/suite/util.py Outdated
log.debug('got response: %s', resp.json())
log.error('can''t find %d parents of %s in %s: %s',
int(count), sha1, project, resp.json()['error'])
int(count), sha1, project, resp.json())
Copy link
Member Author

@kamoltat kamoltat Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes: https://tracker.ceph.com/issues/64820

@kamoltat kamoltat requested review from VallariAg and zmc March 13, 2024 21:15
@kamoltat kamoltat mentioned this pull request Mar 13, 2024
Open
zmc
zmc requested changes Mar 22, 2024
View reviewed changes
Copy link
Member

@zmc zmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor changes suggested; have you scheduled a run with this branch? I'd be curious to see it if so

@kamoltat kamoltat force-pushed the wip-ksirivad-teuth-suite-exception branch from 3f548c6 to 27db304 Compare May 8, 2024 14:34
@kamoltat
Copy link
Member Author

kamoltat commented May 8, 2024

integration test failed:

Warning: RNING]: Skipping Galaxy server https://galaxy.ansible.com./ Got an unexpected
86.80 error when getting available versions of collection amazon.aws: Unknown error
86.80 when attempting to call Galaxy at 'https://galaxy.ansible.com/api/':
86.80 'CustomHTTPSConnection' object has no attribute 'cert_file'.
86.80 'CustomHTTPSConnection' object has no attribute 'cert_file'
86.80 ERROR! Unknown error when attempting to call Galaxy at 'https://galaxy.ansible.com/api/': 'CustomHTTPSConnection' object has no attribute 'cert_file'. 'CustomHTTPSConnection' object has no attribute 'cert_file'
------
Dockerfile:22
--------------------
  21 |     COPY requirements.txt requirements.yml ansible.cfg bootstrap /teuthology/
  22 | >>> RUN \
  23 | >>>     cd /teuthology && \
  24 | >>>     mkdir ../archive_dir && \
  25 | >>>     mkdir log && \
  26 | >>>     chmod +x /teuthology/bootstrap && \
  27 | >>>     PIP_INSTALL_FLAGS="-r requirements.txt" ./bootstrap
  28 |     COPY . /teuthology
--------------------
ERROR: failed to solve: process "/bin/sh -c cd /teuthology &&     mkdir ../archive_dir &&     mkdir log &&     chmod +x /teuthology/bootstrap &&     PIP_INSTALL_FLAGS=\"-r requirements.txt\" ./bootstrap" did not complete successfully: exit code: 1
Service 'teuthology' failed to build : Build failed

@VallariAg VallariAg mentioned this pull request May 8, 2024
Closed
@kamoltat
Copy link
Member Author

kamoltat commented May 29, 2024

jenkins retest this please

@kamoltat kamoltat self-assigned this May 29, 2024
@kamoltat kamoltat force-pushed the wip-ksirivad-teuth-suite-exception branch from 47ddc26 to 27db304 Compare May 29, 2024 17:42
@kamoltat kamoltat force-pushed the wip-ksirivad-teuth-suite-exception branch 2 times, most recently from fc1bcd3 to d4df210 Compare June 17, 2024 14:14
VallariAg
VallariAg reviewed Jun 19, 2024
View reviewed changes
@kamoltat kamoltat force-pushed the wip-ksirivad-teuth-suite-exception branch from d4df210 to a2bc796 Compare August 18, 2024 18:04
@kamoltat kamoltat force-pushed the wip-ksirivad-teuth-suite-exception branch from a2bc796 to 340e02b Compare October 2, 2024 19:00
@kamoltat
docs/docker-compose: -x earlier
bd3e7e0 
do it for

/teuthology/teuthlogy.sh

&&

/start.sh

Signed-off-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
@kamoltat
teuthology/suite/run.py: Improve scheduling exceptions
f3380ce 
Added more loggings and utilizes exceptions e.g.,

ScheduleFail, GitError

Signed-off-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
@kamoltat
teuthology/suite: teuthology.suite.main return job_count
13d1c6d 
Signed-off-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
@kamoltat kamoltat force-pushed the wip-ksirivad-teuth-suite-exception branch from 340e02b to 13d1c6d Compare October 15, 2025 14:54
@kamoltat kamoltat requested a review from a team as a code owner October 15, 2025 14:54
@kamoltat kamoltat requested review from VallariAg and amathuria and removed request for a team October 15, 2025 14:54
@kamoltat kamoltat mentioned this pull request Oct 15, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmc zmc zmc requested changes

@VallariAg VallariAg Awaiting requested review from VallariAg VallariAg is a code owner automatically assigned from ceph/teuthology

@amathuria amathuria Awaiting requested review from amathuria amathuria is a code owner automatically assigned from ceph/teuthology

Requested changes must be addressed to merge this pull request.

Assignees

@kamoltat kamoltat

Labels

improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kamoltat @zmc @VallariAg