Add option to specify custom method for has_many relationships creation #1386
Open
chumakoff wants to merge 1 commit intocerebris:masterfrom
Open
Add option to specify custom method for has_many relationships creation #1386chumakoff wants to merge 1 commit intocerebris:masterfrom
chumakoff wants to merge 1 commit intocerebris:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently has_many relations are added to a parent record via
ActiveRecord'scollection<<method. And there is no way to change that.collection<<doesn't always work for complex associations (especially for usingthroughoption)collection<<doesn't provide full control and confidencecollection<<silently ignores invalid recordscollection<<on model level (which is now the only workaround) for API purposes is not a good waySo, there should be a way to specify (and implement on API level) a custom method that appends has_many relationships.
Example