Co-erce non-present values like false to string#1387
Open
bf4 wants to merge 1 commit intocerebris:release-0-9from
Open
Co-erce non-present values like false to string#1387bf4 wants to merge 1 commit intocerebris:release-0-9from
bf4 wants to merge 1 commit intocerebris:release-0-9from
Conversation
f181f59 to
4b9d7c2
Compare
4b9d7c2 to
0e0c4e5
Compare
bf4
commented
Jan 17, 2024
| raw = "false" | ||
| else | ||
| nil # no-op | ||
| end |
Collaborator
Author
There was a problem hiding this comment.
@lgebhardt any objection to this? otherwise false is treated as not present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a resource which calls another resource, and specifically calls 'verify_filters'. We discovered that in 0.9 and 0.10
verify_filtercallsraw.present?which is false when raw isfalse. This change makes the processing of the true and false consistent.All Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: