Skip to content
This repository was archived by the owner on Jun 6, 2020. It is now read-only.

Conversation

@depfu
Copy link
Contributor

@depfu depfu bot commented Mar 19, 2020


🚨 Your version of actionview has known security vulnerabilities 🚨

Advisory: CVE-2020-5267
Disclosed: March 19, 2020
URL: https://groups.google.com/forum/#!topic/rubyonrails-security/55reWMM_Pg8

Possible XSS vulnerability in ActionView

There is a possible XSS vulnerability in ActionView's JavaScript literal
escape helpers. Views that use the j or escape_javascript methods
may be susceptible to XSS attacks.

Versions Affected: All.
Not affected: None.
Fixed Versions: 6.0.2.2, 5.2.4.2

Impact

There is a possible XSS vulnerability in the j and escape_javascript
methods in ActionView. These methods are used for escaping JavaScript string
literals. Impacted code will look something like this:

<script>let a = `<%= j unknown_input %>`</script>

or

<script>let a = `<%= escape_javascript unknown_input %>`</script>

Releases

The 6.0.2.2 and 5.2.4.2 releases are available at the normal locations.

Workarounds

For those that can't upgrade, the following monkey patch may be used:

ActionView::Helpers::JavaScriptHelper::JS_ESCAPE_MAP.merge!(
  {
    "`" => "\\`",
    "$" => "\\$"
  }
)

module ActionView::Helpers::JavaScriptHelper
alias :old_ej :escape_javascript
alias :old_j :j

def escape_javascript(javascript)
javascript = javascript.to_s
if javascript.empty?
result = ""
else
result = javascript.gsub(/(\|</|\r\n|\342\200\250|\342\200\251|[\n\r"']|[`]|[$])/u, JS_ESCAPE_MAP)
end
javascript.html_safe? ? result.html_safe : result
end

alias :j :escape_javascript
end


🚨 We recommend to merge and deploy this update as soon as possible! 🚨

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rails (5.2.1 → 5.2.4.2) · Repo

Release Notes

5.2.4.1

More info than we can show here.

5.2.4

More info than we can show here.

5.2.3

More info than we can show here.

5.2.2

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ actioncable (indirect, 5.2.1 → 5.2.4.2) · Repo · Changelog

Release Notes

5.2.4.1

More info than we can show here.

5.2.4

More info than we can show here.

5.2.3

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ actionmailer (indirect, 5.2.1 → 5.2.4.2) · Repo · Changelog

Release Notes

5.2.4.1

More info than we can show here.

5.2.4

More info than we can show here.

5.2.3

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ actionpack (indirect, 5.2.1 → 5.2.4.2) · Repo · Changelog

Release Notes

5.2.4.1

More info than we can show here.

5.2.4

More info than we can show here.

5.2.3

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ actionview (indirect, 5.2.1 → 5.2.4.2) · Repo · Changelog

Release Notes

5.2.4.1

More info than we can show here.

5.2.4

More info than we can show here.

5.2.3

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ activejob (indirect, 5.2.1 → 5.2.4.2) · Repo · Changelog

Release Notes

5.2.4.1

More info than we can show here.

5.2.4

More info than we can show here.

5.2.3

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ activemodel (indirect, 5.2.1 → 5.2.4.2) · Repo · Changelog

Release Notes

5.2.4.1

More info than we can show here.

5.2.4

More info than we can show here.

5.2.3

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ activerecord (indirect, 5.2.1 → 5.2.4.2) · Repo · Changelog

Release Notes

5.2.4.1

More info than we can show here.

5.2.4

More info than we can show here.

5.2.3

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ activestorage (indirect, 5.2.1 → 5.2.4.2) · Repo · Changelog

↗️ activesupport (indirect, 5.2.1 → 5.2.4.2) · Repo · Changelog

Release Notes

5.2.4.1

More info than we can show here.

5.2.4

More info than we can show here.

5.2.3

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ builder (indirect, 3.2.3 → 3.2.4) · Repo · Changelog

↗️ concurrent-ruby (indirect, 1.0.5 → 1.1.6) · Repo · Changelog

Release Notes

1.1.6 (from changelog)

More info than we can show here.

1.1.5 (from changelog)

More info than we can show here.

1.1.4 (from changelog)

More info than we can show here.

1.1.0

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ crass (indirect, 1.0.4 → 1.0.6) · Repo · Changelog

Release Notes

1.0.6

More info than we can show here.

1.0.5

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 8 commits:

↗️ erubi (indirect, 1.7.1 → 1.9.0) · Repo · Changelog

Release Notes

1.9.0 (from changelog)

More info than we can show here.

1.8.0 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 18 commits:

↗️ globalid (indirect, 0.4.1 → 0.4.2) · Repo · Changelog

Release Notes

0.4.2

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 20 commits:

↗️ i18n (indirect, 1.1.0 → 1.8.2) · Repo · Changelog

Release Notes

1.8.2

More info than we can show here.

1.2.0

More info than we can show here.

1.1.1

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ loofah (indirect, 2.2.2 → 2.4.0) · Repo · Changelog

Release Notes

2.4.0

More info than we can show here.

2.3.1

More info than we can show here.

2.3.0 (from changelog)

More info than we can show here.

2.2.3

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 59 commits:

↗️ mail (indirect, 2.7.0 → 2.7.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 20 commits:

↗️ method_source (indirect, 0.9.0 → 0.9.2) · Repo

Commits

See the full diff on Github. The new version differs by 12 commits:

↗️ mimemagic (indirect, 0.3.2 → 0.3.4) · Repo · Changelog

Release Notes

0.3.4 (from changelog)

More info than we can show here.

0.3.3 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 31 commits:

↗️ mini_mime (indirect, 1.0.1 → 1.0.2) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 13 commits:

↗️ mini_portile2 (indirect, 2.3.0 → 2.4.0) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ minitest (indirect, 5.11.3 → 5.14.0) · Repo · Changelog

Release Notes

5.14.0 (from changelog)

More info than we can show here.

5.13.0 (from changelog)

More info than we can show here.

5.12.2 (from changelog)

More info than we can show here.

5.12.1 (from changelog)

More info than we can show here.

5.12.0 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 54 commits:

↗️ nio4r (indirect, 2.3.1 → 2.5.2) · Repo · Changelog

Release Notes

2.5.2 (from changelog)

More info than we can show here.

2.4.0 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 67 commits:

↗️ nokogiri (indirect, 1.8.5 → 1.10.9) · Repo · Changelog

Release Notes

1.10.9

More info than we can show here.

1.10.8

More info than we can show here.

1.10.7

More info than we can show here.

1.10.6

More info than we can show here.

1.10.5

More info than we can show here.

1.10.4

More info than we can show here.

1.10.3

More info than we can show here.

1.10.2

More info than we can show here.

1.10.1

More info than we can show here.

1.10.0

More info than we can show here.

1.9.1

More info than we can show here.

1.9.0

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rails-html-sanitizer (indirect, 1.0.4 → 1.3.0) · Repo · Changelog

Release Notes

1.3.0

More info than we can show here.

1.2.0

More info than we can show here.

1.1.0

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 30 commits:

↗️ railties (indirect, 5.2.1 → 5.2.4.2) · Repo · Changelog

Release Notes

5.2.4.1

More info than we can show here.

5.2.4

More info than we can show here.

5.2.3

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ sprockets (indirect, 3.7.2 → 4.0.0) · Repo · Changelog

Release Notes

4.0.0 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ thor (indirect, 0.20.0 → 1.0.1) · Repo · Changelog

Release Notes

1.0.1 (from changelog)

More info than we can show here.

1.0.0 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ tzinfo (indirect, 1.2.5 → 1.2.6) · Repo · Changelog

Release Notes

1.2.6

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 27 commits:

↗️ websocket-driver (indirect, 0.7.0 → 0.7.1) · Repo · Changelog

Release Notes

0.7.1 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 14 commits:

↗️ websocket-extensions (indirect, 0.1.3 → 0.1.4) · Repo · Changelog

Release Notes

0.1.4 (from changelog)

More info than we can show here.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 7 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu
Copy link
Contributor Author

depfu bot commented May 18, 2020

Closed in favor of #73.

@depfu depfu bot closed this May 18, 2020
@depfu depfu bot deleted the depfu/update/group/rails-5.2.4.2 branch May 18, 2020 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant