CER-893 Feature/eloqua plugin to sd kv5 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneldanza
changed the title
rolfisub
reviewed
May 3, 2019
src/eloqua/eloqua.js
Outdated
| paths: { | ||
| elq: "//img.en25.com/i/elqCfg.min", | ||
| CerosSDK: "//sdk.ceros.com/standalone-player-sdk-v3" | ||
| CerosSDK: '//sdk.ceros.com/standalone-player-sdk-v5' |
There was a problem hiding this comment.
Technically single or double quotes don't make a difference in js, but I like to keep consistency with the rest of the file, so if the file is already using double quotes I would use that.
Author
There was a problem hiding this comment.
I've updated the single quotes to double quotes, committed and pushed the change. Please let me know what my next steps should be.
Author
There was a problem hiding this comment.
Should I click on 'Merge pull request'? It is my first time going through this procedure, so I'm a little unsure what I should do next to complete the change.
There was a problem hiding this comment.
After code 👍 you'll need a functional 👍 from QA or someone who tests the story before merging
|
Code 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the CerosSDK link from //sdk.ceros.com/standalone-player-sdk-v3 to //sdk.ceros.com/standalone-player-sdk-v5.
Updated experience.subscribe to experience.on and PAGE_CHANGE to PAGE_CHANGED to be in sync with sdk-v5.