Skip to content

upgrading cloudbuild for stage, publish#252

Open
hjoshi123 wants to merge 1 commit intocert-manager:masterfrom
hjoshi123:feat/upgrade-cloudbuild
Open

upgrading cloudbuild for stage, publish#252
hjoshi123 wants to merge 1 commit intocert-manager:masterfrom
hjoshi123:feat/upgrade-cloudbuild

Conversation

@hjoshi123
Copy link

Changing defaults for our cloudbuild releases

@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Feb 28, 2026
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign munnerz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 28, 2026
@erikgb erikgb requested a review from Copilot February 28, 2026 13:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Cloud Build configuration defaults for release workflows (stage/publish) by standardizing the configured machine type in both the YAML build configs and the cmrel CLI’s defaulting behavior.

Changes:

  • Set options.machineType explicitly in gcb/stage/cloudbuild.yaml and gcb/publish/cloudbuild.yaml.
  • Update cmrel stage / cmrel makestage default machine type string to N1_HIGHCPU_32.
  • Add a cmrel publish default machine type of E2_HIGHCPU_32 when build options are missing.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
gcb/stage/cloudbuild.yaml Adds options.machineType and removes the old/duplicate machine type config.
gcb/publish/cloudbuild.yaml Adds options.machineType for publish builds.
cmd/cmrel/cmd/stage.go Updates default machine type string for stage when options are absent.
cmd/cmrel/cmd/publish.go Adds default machine type for publish when options are absent.
cmd/cmrel/cmd/makestage.go Updates default machine type string for makestage when options are absent.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hjoshi123
Copy link
Author

/cc @maelvls

@cert-manager-prow cert-manager-prow bot requested a review from maelvls March 1, 2026 04:39
@hjoshi123 hjoshi123 force-pushed the feat/upgrade-cloudbuild branch from 26754e2 to 47fe3e2 Compare March 1, 2026 05:13
Signed-off-by: Hemant Joshi <mail@hjoshi.me>
@hjoshi123 hjoshi123 force-pushed the feat/upgrade-cloudbuild branch from 47fe3e2 to a4d8f47 Compare March 1, 2026 05:14
@hjoshi123 hjoshi123 requested a review from Copilot March 1, 2026 05:22
@hjoshi123
Copy link
Author

/cc @erikgb

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants