upgrading cloudbuild for stage, publish#252
upgrading cloudbuild for stage, publish#252hjoshi123 wants to merge 1 commit intocert-manager:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
Updates Cloud Build configuration defaults for release workflows (stage/publish) by standardizing the configured machine type in both the YAML build configs and the cmrel CLI’s defaulting behavior.
Changes:
- Set
options.machineTypeexplicitly ingcb/stage/cloudbuild.yamlandgcb/publish/cloudbuild.yaml. - Update
cmrel stage/cmrel makestagedefault machine type string toN1_HIGHCPU_32. - Add a
cmrel publishdefault machine type ofE2_HIGHCPU_32when build options are missing.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| gcb/stage/cloudbuild.yaml | Adds options.machineType and removes the old/duplicate machine type config. |
| gcb/publish/cloudbuild.yaml | Adds options.machineType for publish builds. |
| cmd/cmrel/cmd/stage.go | Updates default machine type string for stage when options are absent. |
| cmd/cmrel/cmd/publish.go | Adds default machine type for publish when options are absent. |
| cmd/cmrel/cmd/makestage.go | Updates default machine type string for makestage when options are absent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/cc @maelvls |
26754e2 to
47fe3e2
Compare
Signed-off-by: Hemant Joshi <mail@hjoshi.me>
47fe3e2 to
a4d8f47
Compare
|
/cc @erikgb |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changing defaults for our cloudbuild releases