Fixed position of ok/cancel buttons of bot config popup#314
Open
mateodurante wants to merge 2 commits intocerttools:developfrom
Open
Fixed position of ok/cancel buttons of bot config popup#314mateodurante wants to merge 2 commits intocerttools:developfrom
mateodurante wants to merge 2 commits intocerttools:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request improves the user interface of the bot configuration popup in IntelMQ Manager by making the OK/Cancel buttons always visible at the bottom of the popup dialog through sticky positioning and improved layout styling.
Changes:
- Added a
.popup-buttonsCSS class container to wrap action buttons with sticky positioning - Fixed indentation in the template from tabs to spaces for consistency
- Implemented flexbox layout for horizontally centered, fixed-width buttons with proper spacing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| intelmq_manager/templates/configs.mako | Fixed indentation (tabs to spaces) and added popup-buttons class to button container div |
| intelmq_manager/static/css/sb-admin-2.css | Added CSS rules for sticky button positioning with flexbox layout, including styling for the container and individual button forms |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the user interface for the network popup dialog in the IntelMQ Manager by introducing a new
popup-buttonscontainer. The changes enhance the layout and styling of the popup's action buttons, making them more visually distinct and user-friendly.Makes the buttons be always visible:
UI improvements for network popup:
.popup-buttonscontainer to the#network-popUpdialog, making the button area sticky at the bottom, spanning full width, and visually separated with a border for better definition. [1] [2].popup-buttonsto have a consistent fixed width, improved spacing, and padding for a more polished and accessible appearance.