fix(cli): preserve case in wordlist path parsing and use canonical paths#16
Merged
cestef merged 2 commits intocestef:devfrom Jun 2, 2025
rjvkn:dev
Merged
fix(cli): preserve case in wordlist path parsing and use canonical paths#16cestef merged 2 commits intocestef:devfrom rjvkn:dev
cestef merged 2 commits intocestef:devfrom
rjvkn:dev
Conversation
Owner
|
nice catch ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves handling of wordlist file paths in two ways:
Preserve Case in Paths
Previously, the CLI parser lowercased the path portion of
path[:key], causing failures on case-sensitive filesystems (e.g., Linux). Now the path is kept exactly as input, fixing these issues.Resolve Canonical Paths
We convert the provided path to its canonical form using
PathBuf::canonicalize(). This resolves symlinks, relative components like.and.., and returns an absolute, normalized path. It ensures the file can be correctly found and accessed.Why?
Impact