Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
and(case-insensitive) as the final delimiter, so the parser should recognize it and preserve the original text when converting references to links.Description
js/verseParser.mjsby addingVERSE_LIST_DELIMITER_REGand updatingsplitVerseListStringto recognizeandand preserve delimiters.js/biblePreviewer.jsinto abuildBibleRegex()helper and extended list continuation matching to includeand, and updated the reference rendering to usesplitVerseListStringso original delimiters (commas, semicolons, andand) are preserved.js/verseParser.test.mjsforandand mixed delimiter cases to validate parsing behavior.cypress/test.htmlandcypress/e2e/link_creation.cy.js) to coverand-separated same-book lists, chapter-context carryover, and delimiter-preservation.Testing
npm test, and all tests passed successfully.npm run lint, which completed without errors.npm run cypress:run, but Cypress failed in this environment due to a missing system dependency (Xvfb), so E2E tests could not be executed here; the new Cypress tests are included and will run in a CI or developer environment with required GUI dependencies installed.Codex Task