On execution, reset timer _before_ firing callback#10
Open
movitto wants to merge 1 commit intochadrem:masterfrom
Open
On execution, reset timer _before_ firing callback#10movitto wants to merge 1 commit intochadrem:masterfrom
movitto wants to merge 1 commit intochadrem:masterfrom
Conversation
Prevents an edge case where a context switch between firing of the callback and timer reset caused nested timers (timer that is launched within another timer callback) to deadlock
Owner
|
Thanks for the PR. When I get some time I'll review the code to make sure this doesn't introduce other problems. Also, I think it makes sense to add the demo you made in issue #9 as a test case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents an edge case where a context switch between firing of the callback and timer reset caused nested timers (timer that is launched within another timer callback) to deadlock.
See issue #9