sbom: Include predicate type as the output SBOM. #2005
+19
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we use the generator key as the format in the generated SBOM (e.g. "spdx"). It's more useful if we can get the predicate type in the output so we can know how to handle and parse it.
| } | ||
|
|
||
| func (sx *SPDX) PredicateType() string { | ||
| return "https://spdx.dev/Document" |
Contributor
There was a problem hiding this comment.
apko doesn't really know/care about this, does it? Attestations are written outside of the apko process IIRC, so this feels like a leaky abstraction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use the generator key as the format in the generated SBOM (e.g. "spdx"). It's more useful if we can get the predicate type in the output so we can know how to handle and parse it.