Fix panic in Address::from_str with invalid ColorIdentifier#73
Merged
azuchi merged 1 commit intochaintope:masterfrom Dec 25, 2025
Merged
Fix panic in Address::from_str with invalid ColorIdentifier#73azuchi merged 1 commit intochaintope:masterfrom
azuchi merged 1 commit intochaintope:masterfrom
Conversation
When fuzztarget feature is enabled, checksum validation is skipped, allowing invalid data to reach ColorIdentifier::from_slice(). The unwrap() call would panic on invalid color identifiers. Replace unwrap() with proper error handling using map_err().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fuzztarget feature is enabled, checksum validation is skipped, allowing invalid data to reach ColorIdentifier::from_slice().
The unwrap() call would panic on invalid color identifiers.
Replace unwrap() with proper error handling using map_err().