-
Notifications
You must be signed in to change notification settings - Fork 0
Optimize sync endpoint with batch operations and fix accessibility issues #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace unused existingFixtures variable with in-memory Map lookup - Add batch database operations (batchUpdateFixture, batchCreateFixtureWithAvailability) - Use batch operations instead of multiple sequential DB calls for better performance - Remove role="button" from dialog backdrop (accessibility fix) - Fix dialog keydown handler to allow Escape key propagation - Replace arbitrary timeouts with proper Playwright waiting mechanisms in tests - Remove unused syncingButton variable in tests - Update test expectations to verify batch operations Co-authored-by: chamika <754909+chamika@users.noreply.github.com>
Deploying tabletennis with
|
| Latest commit: |
ede658a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fb49f3ec.tabletennis.pages.dev |
| Branch Preview URL: | https://copilot-sub-pr-8.tabletennis.pages.dev |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tabletennis | ede658a | Commit Preview URL Branch Preview URL |
Jan 05 2026, 08:23 PM |
Co-authored-by: chamika <754909+chamika@users.noreply.github.com>
Co-authored-by: chamika <754909+chamika@users.noreply.github.com>
Co-authored-by: chamika <754909+chamika@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add fixture synchronization feature from ELTTL
Optimize sync endpoint with batch operations and fix accessibility issues
Jan 5, 2026
chamika
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses performance, testing, and accessibility issues in the fixture sync feature identified in code review.
Performance optimizations
batch()APITest improvements
waitForTimeout()calls with semantic Playwright state checks (locator.waitFor())syncingButtonvariableAccessibility fixes
role="button"+tabindex="0", addrole="presentation"✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.