Support string name in service port: & allow service: name override#60
Open
cpboyd wants to merge 2 commits intochartmuseum:mainfrom
Open
Support string name in service port: & allow service: name override#60cpboyd wants to merge 2 commits intochartmuseum:mainfrom
name in service port: & allow service: name override#60cpboyd wants to merge 2 commits intochartmuseum:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43
namein serviceport:(from Support type string in ingress service port and pathType in ingress path #37, rebased to latest)service:name override for individual servicesExample below uses
service: ssl-redirectwithport: use-annotation.In the current helm release, this doesn't work for two reasons:
service.servicename: helmsupersedes the individual service names, even when they're specified.port.name& string port values.