feat: allow to connect a python rpc-client to an rpc-server via a unix FIFO file instead of subprocess #7535
+113
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpk42
force-pushed
the
hpk/rpc-pipes
branch
10 times, most recently
from
510fbee to
1ab8329
Compare
hpk42
changed the title
link2xt
reviewed
Nov 29, 2025
| fn_response_fifo = tmp_path.joinpath("response_fifo") | ||
| os.mkfifo(fn_request_fifo) | ||
| os.mkfifo(fn_response_fifo) | ||
| popen = subprocess.Popen(f"deltachat-rpc-server <{fn_request_fifo} >{fn_response_fifo}", shell=True) |
Collaborator
There was a problem hiding this comment.
For any real use FIFOs should likely be replaced with the UNIX socket, which exists on all platforms (including Windows) and can handle multiple connections.
Contributor
Author
There was a problem hiding this comment.
makes sense to rather go for UNIX sockets, but i think it's fine to merge this PR already. Shouldn't be too hard to write another RpcUNIXSocket subclass after #7545 is done.
7 tasks
Simon-Laux
reviewed
Jan 12, 2026
|
|
||
|
|
||
| class RpcFIFO(BaseRpc): | ||
| """RPC client that runs and connects to a deltachat-rpc-server through FIFO files.""" |
Contributor
There was a problem hiding this comment.
Suggested change
| """RPC client that runs and connects to a deltachat-rpc-server through FIFO files.""" | |
| """RPC client that connects to a deltachat-rpc-server through FIFO files.""" |
Simon-Laux
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also internally refactors rpc.py a bit and strikes unneccessary
**kwargs