feat: Don't scale up Origin of multiple and broadcast recipients when sending a message #7627
+33
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I suggest we merge this (if there are no other ideas), otherwise already merged #7616 doesn't make much sense |
Simon-Laux
reviewed
Jan 8, 2026
… sending a message 84161f4 promotes group members to `Origin::IncomingTo` when accepting it, instead of `CreateChat` as before, but this changes almost nothing because it happens rarely that the user only accepts a group and writes nothing there soon. Now if a message has multiple recipients, i.e. it's a 3-or-more-member group, or if it's a broadcast message, we don't scale up its recipients to `Origin::OutgoingTo`.
iequidoo
force-pushed
the
iequidoo/lower-origin-for-group-contacts
branch
from
02b90a3 to
b549e76
Compare
Collaborator
Author
|
Fixed also a case for member removal. There's no test for broadcasts, but i can add it if the change itself is agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
84161f4 promotes group members to
Origin::IncomingTowhen accepting it, instead ofCreateChatas before, but this changes almost nothing because it happens rarely that the user only accepts a group and writes nothing there soon. Now if a message has multiple recipients, i.e. it's a 3-or-more-member group, or if it's a broadcast message, we don't scale up its recipients toOrigin::OutgoingTo.Follow-up to #7616
Maybe when accepting a 2-member group it also makes sense to use
Origin::CreateChatas before because it's a "1:1 group"?