api(jsonrpc): add run_until parameter for bots #7688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also makes testing hooks easier, as it allows to process events and run hooks on them, until a certain event occurs.
missytake
force-pushed
the
run-until-rpc
branch
from
1830b9d to
3d492bb
Compare
iequidoo
reviewed
Jan 8, 2026
| until_func: Callable[[AttrDict], bool], | ||
| until_event: EventType = False, | ||
| ) -> AttrDict: | ||
| """Process events until the given callable evaluates to True. |
Collaborator
There was a problem hiding this comment.
The documentation needs to be updated
| self._process_messages() | ||
|
|
||
| stop = func(event) | ||
| if event.kind == until_event: |
Collaborator
There was a problem hiding this comment.
Maybe do this check after calling until_func? Calling it one more time may be useful, e.g. for logging purposes, and it even goes before until_event in the _process_events() parameter list
iequidoo
reviewed
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also makes testing hooks easier, as it allows to process events and run hooks on them, until a certain event occurs.