feat: send vc- prefix instead of vg- in Secure-Join where accepted #7690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/securejoin-vg-prefix
branch
2 times, most recently
from
8f9cad8 to
9ed8869
Compare
link2xt
force-pushed
the
link2xt/securejoin-vg-prefix
branch
from
9ed8869 to
7835b03
Compare
This way we always send `Secure-Join: vc-request`, even when joining the group, and it is not visible to the server if we setup a new contact or join a group/channel.
link2xt
force-pushed
the
link2xt/securejoin-vg-prefix
branch
from
7835b03 to
fe4a1e7
Compare
Collaborator
|
This breaks compatibility with releases before #7198, which was released in v2.16.0. On Android, this was released with https://github.com/deltachat/deltachat-android/releases/tag/v2.22.0 at Oct 22, I didn't check other platforms. Not sure how bad the breakage is, but, we may want to wait |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we always send
Secure-Join: vc-request, even when joining the group,and it is not visible to the server if we setup a new contact or join a group/channel.