fix: Use only lowercase letters for stats id #7700
Open
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hocuri
force-pushed
the
hoc/safer-stats-ids
branch
from
b6c4f90 to
d70beb3
Compare
Hocuri
changed the title
Collaborator
|
But this will not help with existing users who already generated IDs. Can stats ID be encoded instead? |
Collaborator
Author
|
There are only problems when the user takes the survey, and the user only takes the survey when they enable stats sending. So, there is nothing we can do about users who already turned on stats sending. |
Hocuri
force-pushed
the
hoc/safer-stats-ids
branch
from
d70beb3 to
36c6161
Compare
If the user enables statistics-sending in the advanced settings, they will be asked whether they also want to take part in a survey. We use a short ID to then link the survey result to the sent statistics. However, the survey website didn't like our base64 ids. This PR makes it so that the id only contains lowecase letters.
Hocuri
force-pushed
the
hoc/safer-stats-ids
branch
from
36c6161 to
16014a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user enables statistics-sending in the advanced settings, they will be asked whether they also want to take part in a survey. We use a short ID to then link the survey result to the sent statistics.
However, the survey website didn't like our base64 ids, especially the fact that the id could contain a
-. This PR makes it so that the id only contains lowecase letters.