This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Implement Logrus instead of a custom logger inside the infra package.#4
Open
ValentinMontmirail wants to merge 6 commits intochavacava:masterfrom
Open
Implement Logrus instead of a custom logger inside the infra package.#4ValentinMontmirail wants to merge 6 commits intochavacava:masterfrom
Logrus instead of a custom logger inside the infra package.#4ValentinMontmirail wants to merge 6 commits intochavacava:masterfrom
Conversation
Updating packages to the latest versions
…ch a way, logs of dfense can be handled and mix with logs from other applications (in a CI-CD for example).
ValentinMontmirail
changed the title
Logrus instead of a custom logger inside the infra package.
We add only logrus, so no other package should change.
Go.sum should not change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In such a way, logs of dfense can be handled and mix with logs from other applications (in a CI-CD for example).
Thanks to
logrus, we can also provide the option 'trace' where even more logs could be provided.I kept the idea of having colorful logs and also, I add a packages that ensure the colorfulness of logs even on Windows.