Updated Shadowlands Branch #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made it so the rep gain amount wasn't behind the scroll wheel if the amount of mobs exceed the window and required a scroll
Changed the string value from %d to %g to show decimal values on reputation gain. to help with rep gains that give .25-.75 gains and also to help with DMF to be a little more exact with the numbers
Added shadowlands turn in for Korthia rep, added rep gains for Shadowlands areas. Added Brawlers guild rep gain calculations. Possible fix for Wintersaber turn ins. Added Bodyguard rep calculations for Draenor. Fixed guild calculations for quest turn ins. Added all Ve'nari rep mobs & events.
Hadn't noticed, for horde it was causing an error due to wintersaber rep not being alliance only. This fixed it
Author
|
Noticed an error with wintersaber rep on horde toons. It wasn't in an alliance only string. I have since updated and corrected |
Fixed Kiron Tor Fishing, Cooking & Jewelcrafting daily Added Onyx Egg for Order of the Cloud Serpent Fixed quest linked with Highmaul Relics Added Netherstorm general zone quests Added general Chromie scenario for rep towards timelord Updated Gelkis & Magram rep reward, from 1 to 10 million Updated Guild tuurn ins
|
I guess I'll use your branch then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a big user to RepHelper and I love having this addon help me with reputations. I wanted to help others and put in some time to help update the addon to the current build of Shadowlands.
Korthia rep was interesting, I couldn't figure out the tiering part, but it's basically neutral to exalted with the Archivists Codex. Also being that the turn ins give 1 rep per 2 research
Fixed #38
Fixed #26 for missing Kiron tor
I wasn't able to 100% work on Wintersaber rep, I don't have a toon currently on the chain, so hopefully this will update that comment. Fixed some of the zone mobs not showing up in the rep frame correctly, some wasn't showing the area correctly due to a typo of ZONE instead of just zone.
Hopefully this helps and these changes can be pushed live.