Make cec package compatible with libCEC v3.1#2
Open
minorhacks wants to merge 7 commits intochbmuc:masterfrom
minorhacks:master
Open
Make cec package compatible with libCEC v3.1#2minorhacks wants to merge 7 commits intochbmuc:masterfrom minorhacks:master
minorhacks wants to merge 7 commits intochbmuc:masterfrom
minorhacks:master
Conversation
…C debug info to level 2 verbosity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered today that this package doesn't build when following the directions in the README. It looks like the API to libcec has changed - a number of functions have been renamed from cec_* to libcec_*, also taking an additional libcec_connection_t parameter. The bulk of the important changes are: save off the libcec_connection_t value received from libcec_initialise() into a global, and use this value for subsequent libcec_* calls that require it.
I replaced the 'log' package with the 'glog' package, which allows for different logging levels (Info, Warning, Error) and different verbosities. CEC debug info that is logged in callbacks.go can be logged at a higher verbosity level so that it doesn't always have to be visible. I updated the README file with the additional step required (flag.Parse()) and flag information.
I ran gofmt on all the files, so there are a lot of whitespace changes.