Skip to content

Conversation

@pavithra-suresh
Copy link
Contributor

Addressing the PR review comments
#191

Below are the changes:

  • Have a new menu item added in PrimaryView.fxml (like "File" -> "Export to JSON")
  • PrimaryView.kt will have a new method to handle a menu event
  • This method will be similar to openRecordingFile - it should create a CallRecordTree instance. This will trigger reading from the recording file in a background thread
  • Listener (anonymous class which implements RecordingListener) should capture all Recording instances.
  • When reading is complete (there is a CompletableFuture to indicate that callRecordTree.completeFuture), we can take call tree root and export to JSON.
Screenshot 2026-01-28 at 2 27 08 PM

PavithraSuresh added 5 commits August 20, 2025 18:31
# Conflicts:
#	gradle.properties
#	ulyp-agent-api/build.gradle
#	ulyp-agent/build.gradle
#	ulyp-common/build.gradle
#	ulyp-common/src/main/java/com/ulyp/core/serializers/EnterMethodCallSerializer.java
#	ulyp-ui/build.gradle
#	ulyp-ui/src/main/kotlin/com/ulyp/ui/PrimaryView.kt
@sonarqubecloud
Copy link

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove all those files from the PR? they are already in .gitignore, I don't think they should be in the repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been incorported

@pavithra-suresh pavithra-suresh requested a review from cheb0 February 4, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants