Issue #18064: added ArrayBracketNoWhitespace check

[M-SaaD-H]

fixes #18064

New module config: https://gist.githubusercontent.com/M-SaaD-H/c0e73c4661d662cf719263dd62c5729b/raw/fbd2af1abffb6b6e9c90081a71d74c0ddbfd0bdc/gistfile1.txt

Contribution repo: checkstyle/contribution#1007

[romani]

Please read and watch videos at Starting_Development.
Please make CI green.

[M-SaaD-H]

Hi @romani ,
I have tested the check locally before raising the PR, but overlooked the XpathRegression tests. I am sorry for this, but I am facing some issues in passing these tests. I have asked this in the discord channel but didn't got the solution from there too. It will be really helpful if you could help me in understanding and solving this issue.
Tagged you in the related thread on discord.

[romani]

Just debug test and trace all lines to understand why there is no violation. All is debug-able.

[SURYANSHUAGRAWAL2006]

@saad please make sure commit should be only one so, please squash all commits into single one.

[mohitsatr]

@M-SaaD-H please push the changes so we can see what's wrong with XpathRegression tests. It's little hard to understand from images.

[M-SaaD-H]

@mohitsatr I have pushed the code.
Please look into it.

[M-SaaD-H]

Hi @mohitsatr can you please look into the CIs, I can't really get why they are failing.

[SURYANSHUAGRAWAL2006]

Hello Saad my advice is that you have to be run the command mvn clean verify again and run this command again and again until BUILD SUCCESS will not encountered because same error also came in my checks so I simply did to ran command mvn clean verify and when BUILD SUCCESS showing then I push my code and all checks passed.
so, please go through this.

[M-SaaD-H]

Hi @SURYANSHUAGRAWAL2006 ,
Thanks for your advice. I have already verified that build is success locally. I am getting BUILD SUCCESS message when I run mvn clean verify. This error is only showing when I push my changes. Moreover, I can't find the actual reason for the failure of these CI pipelines.

[vivek-0509]

For the run-inspections failure open the ci failes they have given this link
https://app.circleci.com/pipelines/github/checkstyle/checkstyle/38573/workflows/43e71112-f6c4-4ca9-8d52-4a0ed937de87/jobs/1167874/artifacts

you will se the inspections result open those links and fix those issues

Similarly for other CI failures check the logs

[SURYANSHUAGRAWAL2006]

Hello Saad I saw your build failure this is occurring not because of your code or check style it is because of maven problem so, Kindly rerun all CI best way close the pr then reopen the pr then all CI will run again and then you check all CI is passing or not but I am sure this is not your code problem rather than it is problem of maven internal.

[M-SaaD-H]

Hi @romani
Can you please look into it?

[mohitsatr]

@M-SaaD-H Green CI is a good sign. Take to run regression.

Please go through the section Executing generation using github action and try to generate the report.

Example PR: #17329

[M-SaaD-H]

GitHub, generate report

[github-actions]

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/20280771915

[github-actions]

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/20280805281

[mohitsatr]

@M-SaaD-H Config in the Pr's description is not valid. It has to be like: https://gist.githubusercontent.com/mohitsatr/0e04070f847926ea44bf7eda88706807/raw/f9470db307d730a651e9c93cad776d6b592839e8/textblockgooglestyleformatting.xml. Replace Textb...Check with your check

[M-SaaD-H]

Hi @romani ,
I’ve addressed all the review comments from earlier.
Please let me know if anything else is needed from my side.
Thanks!

[romani]

items:

[romani]

please rebase on most latest code.

[romani]

GitHub, generate website

[romani]

@M-SaaD-H , can you explain this violation
https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/4d1133d_2025073844/reports/diff/guava/index.html#A1 I did not get what is expected code ?

can you google formatter onthis snippet by CLI and share output.

[M-SaaD-H]

@romani , the violation that you pointed out is
byte[] expected = {bytes[4], bytes[5]};
and the expected (according to the current implementation) is
byte[] expected = { bytes[4], bytes[5] };

However, ArrayBracketNoWhitespaceCheck should not require whitespace between ] and } here, so the existing format looks correct to me. If you want this enforced, I can update the test, please confirm.

[M-SaaD-H]

@romani , I ran google-java-format on the file via CLI. The formatter does not change this line, so it doesn’t consider it a formatting issue.

[github-actions]

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/4d67faa_20260130104506/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/4d67faa_20260130104506/checks.html#Standard_Checks

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/4d67faa_20260130104506/checks/whitespace/arraybracketnowhitespace.html#

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/4d67faa_20260130104506/checks/whitespace/index.html#Whitespace_Checks

[romani]

items:

[romani]

However, ArrayBracketNoWhitespaceCheck should not require whitespace between ] and } here, so the existing format looks correct to me. If you want this enforced, I can update the test, please confirm.

this is false positive, please fix.

[romani]

GitHub, generate website

[romani]

GitHub, generate website

[M-SaaD-H]

GitHub, generate website

[github-actions]

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/78e1dac_20260130155936/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/78e1dac_20260130155936/checks.html#Standard_Checks

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/78e1dac_20260130155936/checks/whitespace/arraybracketnowhitespace.html#

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/78e1dac_20260130155936/checks/whitespace/index.html#Whitespace_Checks

[github-actions]

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/78e1dac_20260130190546/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/78e1dac_20260130190546/checks.html#Standard_Checks

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/78e1dac_20260130190546/checks/whitespace/arraybracketnowhitespace.html#

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/78e1dac_20260130190546/checks/whitespace/index.html#Whitespace_Checks

[vivek-0509]

@M-SaaD-H
There are a lot of surviving mutants please eliminate them
https://github.com/checkstyle/checkstyle/actions/runs/21519356239/job/62005978578?pr=18240

[M-SaaD-H]

Hi @vivek-0509
I have killed most of the muatations, but there still exists one.
And for it to be killed the VARIABLE_DEF token need to be the closest valid token after ] on the same line (something like []int) which is not a valid java syntax. Is there a way to suppress this mutation? or how else should I proceed?

[vivek-0509]

@M-SaaD-H This means the VARIABLE_DEF token does nothing and is effectively dead code since a VARIABLE_DEF token can never appear closest after a ]. We can safely remove it and verify that everything works correctly without it.

[M-SaaD-H]

@vivek-0509
I tried that, but that causes much more mutations. I didn't had much time yesterday due to some problems but I'll be working on it.