Take a look at that needs-refactoring!

[szepeviktor]

From #98

[szepeviktor]

Cure

• some generics
• some imaginary stubs

Sending commits ....

[szepeviktor]

@chesio Done 🍏

Please prefer the new list<bla> notation instead the old bla[]

[chesio]

Hi @szepeviktor,

Thanks for the PR.

Generics are completely new stuff for me, do you have some online resources you would recommend to read?

I'm not sure about including the WP_List_Table stub - seems a bit overkill for me to "duplicate" entire class just to be able to increase test level.

[szepeviktor]

Generics are completely new stuff for me, do you have some online resources you would recommend to read?

See the link on the word "generics" :)

seems a bit overkill for me to "duplicate" entire class

1. it contains no code, it is a stub
2. you don't have to distribute it through Composer/GitHub ZIP
3. there is only 1 other way to make $item an array vs. object in core's docblocks: write a lot of PHPStan code to force types...

[szepeviktor]

Please take a look at what PHPStan level is the default for this tiny project: https://github.com/szepeviktor/unique-email-address

[szepeviktor]

@chesio Friendly ping 🏓

(from the far away past)

[chesio]

@szepeviktor,

thanks for the ping, I might have time to review it tomorrow.