This repository was archived by the owner on Jul 8, 2021. It is now read-only.
Rename voices method and allow all languages #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chezou
suggested changes
Apr 27, 2017
Owner
chezou
left a comment
chezou
left a comment
There was a problem hiding this comment.
Thank you for your PR. I made a few comments. Could you check them?
| voices = client.describe_voices(language_code: language_code) | ||
| voices.voices if voices | ||
| def voices(language=nil) | ||
| client.describe_voices(language_code: language).voices |
Owner
There was a problem hiding this comment.
Is it safe if client.describe_voices(...) returns nil?
Author
There was a problem hiding this comment.
In which use case do you think it returns nil? If you send an unrecognized language to AWS, an exception is raised either way. Any use case I missed?
| def available_voices_in(language_code: 'en-US') | ||
| voices = client.describe_voices(language_code: language_code) | ||
| voices.voices if voices | ||
| def voices(language=nil) |
Owner
There was a problem hiding this comment.
I don't think it is necessary to change method name.
Author
There was a problem hiding this comment.
It kinda is.... since it now allows all languages (i.e. accept no arguments), you end up with a broken sentence: synth.available_voices_in... in what?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the method
#available_voices_into#voices, and in addition, allows getting voices in all languages in one call.Example usage:
Closes #1